| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: advance local xmin more aggressively |
| Date: | 2014-12-22 10:31:15 |
| Message-ID: | 5497F2F3.2050403@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/16/2014 10:41 PM, Jeff Janes wrote:
> On Wed, Dec 10, 2014 at 3:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>> On Wed, Dec 10, 2014 at 3:28 PM, Heikki Linnakangas
>> <hlinnakangas(at)vmware(dot)com> wrote:
>>>> Care to code it up?
>>>
>>> Here you are.
>>
>> That was quick.
>>
>> You need to add a semicolon to the end of line 20 in pairingheap.c.
>
> In addition to the semicolon, it doesn't build under cassert. There are
> some pairingheap_empty that need to be pairingheap_is_empty, and snapmgr.c
> needs an address of operator near line 355 and something is wrong
> in snapmgr.c near line 811.
Here's an updated version, rebased over the pairing heap code that I
just committed, and fixing those bugs.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| advance-xmin-more-with-heap-2.patch | text/x-diff | 10.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2014-12-22 11:20:25 | Re: inherit support for foreign tables |
| Previous Message | Heikki Linnakangas | 2014-12-22 10:16:11 | Moving src/backend/utils/misc/rbtree.c to src/backend/lib |