| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal: Log inability to lock pages during vacuum |
| Date: | 2014-12-18 20:06:57 |
| Message-ID: | 549333E1.2090004@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/18/2014 09:41 PM, Alvaro Herrera wrote:
> Jim Nasby wrote:
>
>> We have to decide on a tradeoff here. Either we end up with two
>> different log messages (depending on scan_all) that require two
>> different translations, or we end up with a generic message that isn't
>> as clear.
>>
>> The best option I can think of for the later is something like "failed
>> initial lock attempt". That's the only thing that will be true in all
>> cases.
>
> Here's my proposal. Instead of punting, I split the message in
> separately translatable units, and emit only the ones that apply. The
> code is messier this way, but I think we can live with that.
Works for me.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-12-18 20:21:36 | Re: Proposal: Log inability to lock pages during vacuum |
| Previous Message | Alvaro Herrera | 2014-12-18 19:41:04 | Re: Proposal: Log inability to lock pages during vacuum |