Re: Commitfest problems

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Commitfest problems
Date: 2014-12-16 18:13:16
Message-ID: 5490763C.5080808@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/16/2014 08:48 AM, Mike Blackwell wrote:
> On Tue, Dec 16, 2014 at 10:15 AM, Mark Cave-Ayland
> <mark(dot)cave-ayland(at)ilande(dot)co(dot)uk <mailto:mark(dot)cave-ayland(at)ilande(dot)co(dot)uk>>wrote:
>
>
> Well as I mentioned in my last email, practically all developers will
> rebase and run "make check" on their patched tree before submitting to
> the list.
>
>
> ​Even when this is true, and with people new to the project submitting
> patches
> I'm not sure it can be assumed, time passes and things can change between
> submission​ and review. I've seen a fair number of "Needs rebase" comments
> on patches, through no fault of the original submitter.

This really should be taken care of by automation. Magnus's new system
will be a significant step forwards on enabling that.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-12-16 18:21:49 Re: Commitfest problems
Previous Message Teodor Sigaev 2014-12-16 17:48:25 Re: compress method for spgist - 2