| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GiST kNN search queue (Re: KNN-GiST with recheck) |
| Date: | 2014-12-16 09:23:56 |
| Message-ID: | 548FFA2C.7060000@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/15/2014 11:59 PM, Jeff Janes wrote:
> On Mon, Dec 15, 2014 at 5:08 AM, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com
>> wrote:
>
> Here's a new version of the patch. It now uses the same pairing heap code
>> that I posted in the other thread ("advance local xmin more aggressivley",
>> http://www.postgresql.org/message-id/5488ACF0.8050901@vmware.com). The
>> pairingheap_remove() function is unused in this patch, but it is needed by
>> that other patch.
>
> Under enable-cassert, this tries to call pairingheap_empty, but that
> function doesn't exist.
>
> I looked in the other patch and didn't find it defined there, either.
Ah, I renamed pairingheap_empty to pairingheap_is_empty at the last
minute, and missed the Asserts. Here's a corrected version.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| knn-gist-pairingheap-3.patch | text/x-diff | 19.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2014-12-16 09:34:47 | Re: pg_basebackup vs. Windows and tablespaces |
| Previous Message | Satoshi Nagayasu | 2014-12-16 09:23:04 | Re: pg_rewind in contrib |