Re: Commitfest problems

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Commitfest problems
Date: 2014-12-11 22:02:53
Message-ID: 548A148D.9050300@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/11/2014 01:52 PM, Alvaro Herrera wrote:
> Bruce Momjian wrote:
>> On Thu, Dec 11, 2014 at 01:12:30PM -0800, Joe Conway wrote:
>
>>> Actually, to me it sounds a lot like what we did 10 years ago before
>>> the commitfests except with a way to track the patches (other than the
>>> mail archives) and more people participating in patch reviews.
>>
>> Yes, it does remind me of the mbox files I put on the web.
>
> The whole commitfest process was put in place in part precisely so we
> could get rid of your mboxen. Please let's not get back to that!

Well, the CF process was added for 2 reasons:

1) We were losing track of some patches until integration time, when
Bruce suddently found them in the -hackers archives.

2) In order to give the senior committers some time *off* from reviewing
other people's patches. The idea was to spend 3 weeks or so intensively
reviewing others' patches, and then to have a month (or more) *off* from
working on anything but your own stuff.

While the CFs are still doing (1), support for (2) ended sometime in the
9.3 development cycle. Partly this is because current CFMs are not
permitted to take authoritative steps to ensure that the CF ends on
time, and partly it's because of the increase in big complicated patches
which just don't fit into the CF cycle.

Speaking as the originator of commitfests, they were *always* intended
to be a temporary measure, a step on the way to something else like
continuous integration.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-12-11 22:05:07 Re: Commitfest problems
Previous Message David G Johnston 2014-12-11 22:01:29 Re: Commitfest problems