Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Mark Dilger <mark(at)port25(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended
Date: 2014-12-11 08:21:43
Message-ID: 54895417.7010809@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/11/2014 05:57 AM, Michael Paquier wrote:
> On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger <mark(at)port25(dot)com> wrote:
>
>> At line 1787 of outfuncs.c, the line:
>>
>> WRITE_UINT_FIELD(reltablespace)
>>
>> should probably say
>>
>> WRITE_OID_FIELD(reltablespace)
>>
>> since that variable is of type Oid, not uint32.
>> Granted, these two macros are interchangeable,
>> but they won't be if we ever move to 64-bit Oids.
>>
> For correctness you are right. Looks like you spent quite some time looking
> at that..

Fixed, thanks.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Reiss 2014-12-11 08:41:08 Re: Casting issues with domains
Previous Message Rahila Syed 2014-12-11 07:56:38 Re: [REVIEW] Re: Compression of full-page-writes