| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alex Shulgin <ash(at)commandprompt(dot)com>, Christoph Berg <cb(at)df7cb(dot)de> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add shutdown_at_recovery_target option to recovery.conf |
| Date: | 2014-11-28 16:59:16 |
| Message-ID: | 5478A9E4.3000706@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 28/11/14 17:46, Alex Shulgin wrote:
>
> Christoph Berg <cb(at)df7cb(dot)de> writes:
>
>> Re: Petr Jelinek 2014-11-25 <5474EFEA(dot)2040000(at)2ndquadrant(dot)com>
>>>> Patch committed.
>
> Before I go and rebase that recovery.conf -> GUC patch on top of
> this... is it final?
>
I think so, perhaps sans the name mentioned below.
>>>
>>> Thanks!
>>
>> I'm a bit late to the party, but wouldn't
>>
>> recovery_target_action = ...
>>
>> have been a better name for this? It'd be in line with the other
>> recovery_target_* parameters, and also a bit shorter than the imho
>> somewhat ugly "action_at_recovery_target".
>
> FWIW, I too think that "recovery_target_action" is a better name.
>
I agree.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-11-28 18:01:02 | Re: no test programs in contrib |
| Previous Message | Alex Shulgin | 2014-11-28 16:46:16 | Re: Add shutdown_at_recovery_target option to recovery.conf |