Re: postgres_fdw behaves oddly

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres_fdw behaves oddly
Date: 2014-11-18 08:25:20
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

(2014/11/17 19:54), Ashutosh Bapat wrote:
> Here are comments for postgres_fdw-syscol patch.

Thanks for the review!

> Code
> -------
> 1. Instead of a single liner comment "System columns can't be sent to
> remote.", it might be better to explain why system columns can't be sent
> to the remote.


> 2. The comment in deparseVar is single line comment, so it should start
> and end on the same line i.e. /* and */ should be on the same line.


> 3. Since there is already a testcase which triggered this particular
> change, it will good, if we add that to regression in postgres_fdw.


Please find attached an updated version of the patch.


Best regards,
Etsuro Fujita

Attachment Content-Type Size
postgres_fdw-syscol-v2.patch text/x-diff 2.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-11-18 08:28:39 Re: WAL format and API changes (9.5)
Previous Message Etsuro Fujita 2014-11-18 08:20:02 Re: postgres_fdw behaves oddly