Re: Teaching pg_dump to use NOT VALID constraints

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Teaching pg_dump to use NOT VALID constraints
Date: 2014-11-14 00:30:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 11/13/14 5:07 AM, Simon Riggs wrote:
> On 13 November 2014 00:20, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> wrote:
>> Isn't the real use-case here that if constraints were valid when you dumped
>> then we shouldn't have to *any* re-validate when we load? (Though, we'd have
>> to be careful of that with CHECK because that can call user code...)
> Yes, that is the use case this patch would improve considerably.

But your patch doesn't really address that. It just leaves the
constraints as invalid, and someone will have to revalidate them later
(how?). What Jim was describing was a mode that creates the constraints
as valid but doesn't actually validate them. I can see both sides of
that kind of feature.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-11-14 00:34:39 Re: [GENERAL] Performance issue with libpq prepared queries on 9.3 and 9.4
Previous Message Simon Riggs 2014-11-14 00:27:07 Re: using custom scan nodes to prototype parallel sequential scan