Re: row_to_json bug with index only scans: empty keys!

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Ross Reedstrom <reedstrm(at)rice(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: row_to_json bug with index only scans: empty keys!
Date: 2014-11-08 21:32:25
Message-ID: 545E8BE9.7020802@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 11/08/2014 04:19 PM, Ross Reedstrom wrote:
> I've no opinion on the not respecting aliases aspect of this, but both
> the hstore and json emtpy keys case breaks the format: it's duplicate keys
> that collapse to a single value, and expected keynames are missing.
>
> The insidious bit about this bug though is that it works fine during testing
> with the developers typically small data sets. It's only triggered in my case
> when we the plan switches to index-only. Even an index scan works fine. I can't
> imagine that there is code out there that _depends_ on this behavior. Just as
> likely to me are that there exist systems that just have "can't reproduce" bugs
> that would be fixed by this.
>
>

No, I can't imagine it either - it's utterly broken. That's the piece
that Tom is proposing to fix on the back branches. AIUI.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-11-08 21:35:36 Re: Add CREATE support to event triggers
Previous Message Ross Reedstrom 2014-11-08 21:19:36 Re: row_to_json bug with index only scans: empty keys!