Re: tracking commit timestamps

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Subject: Re: tracking commit timestamps
Date: 2014-11-04 21:20:47
Message-ID: 5459432F.4010004@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On 11/3/14 5:17 PM, Petr Jelinek wrote:
>> Please don't name anything "committs". That looks like a misspelling of
>> something.
>>
>> There is nothing wrong with
>>
>> pg_get_transaction_commit_timestamp()
>>
>> If you want to reduce the length, lose the "get".
>>
>
> I am fine with that, I only wonder if your definition of "anything" only
> concerns the SQL interfaces or also the internals.

I'd be fine with commit_ts for internals, but not committs.

One day, you'll need a function or data structure that works with
multiple of these, and then you'll really be in naming trouble. ;-)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2014-11-04 21:26:48 Re: tracking commit timestamps
Previous Message Petr Jelinek 2014-11-04 21:15:51 Re: tracking commit timestamps

Browse pgsql-www by date

  From Date Subject
Next Message Petr Jelinek 2014-11-04 21:26:48 Re: tracking commit timestamps
Previous Message Petr Jelinek 2014-11-04 21:15:51 Re: tracking commit timestamps