From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
Subject: | Re: tracking commit timestamps |
Date: | 2014-11-03 21:26:11 |
Message-ID: | 5457F2F3.6070308@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
On 11/1/14 8:04 AM, Petr Jelinek wrote:
> On second thought, maybe those should be pg_get_transaction_committs,
> pg_get_transaction_committs_data, etc.
Please don't name anything "committs". That looks like a misspelling of
something.
There is nothing wrong with
pg_get_transaction_commit_timestamp()
If you want to reduce the length, lose the "get".
> For me the commit time thing feels problematic in the way I perceive it
> - I see commit time as a point in time, where I see commit timestamp (or
> committs for short) as something that can recorded. So I would prefer to
> stick with commit timestamp/committs.
In PostgreSQL, it is pretty clearly established that time is hours,
minutes, seconds, and timestamp is years, months, days, hours, minutes,
seconds. So unless this feature only records the hour, minute, and
second of a commit, it should be "timestamp".
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2014-11-03 21:36:14 | Re: TAP test breakage on MacOS X |
Previous Message | Alexey Vasiliev | 2014-11-03 21:25:34 | Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code |
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2014-11-03 22:17:38 | Re: tracking commit timestamps |
Previous Message | Alvaro Herrera | 2014-11-03 20:36:48 | Re: tracking commit timestamps |