Re: Lessons from commit fest

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Chris Browne <cbbrowne(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Lessons from commit fest
Date: 2008-04-17 00:15:54
Message-ID: 5453.1208391354@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I am reviewing the psql wrap patch and just used pgindent today to clean
> it up. (pgindent did not add any extra spacing changes.) Patch
> reviewers should probably be able to run pgindent.

Well, that means nobody in the world can review except you, because
nobody else has ever reported success in duplicating your pgindent
results. I know I haven't been able to.

If you really believe the above then you need to try a bit harder
to find a portable version of indent that we all can use.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-17 00:17:41 Re: Lessons from commit fest
Previous Message Gregory Stark 2008-04-17 00:08:46 Re: Lessons from commit fest