| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "PostgreSQL mailing lists" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make pg_controldata accept "-D dirname" |
| Date: | 2014-10-24 16:20:51 |
| Message-ID: | 544A7C63.5010209@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/24/2014 11:36 AM, Michael Paquier wrote:
> On Thu, Sep 25, 2014 at 12:38 PM, Heikki Linnakangas <
> hlinnakangas(at)vmware(dot)com> wrote:
>
>> On 09/24/2014 05:48 PM, Abhijit Menon-Sen wrote:
>>
>>> Updated patches attached.
>>>
>>
>> Thanks, applied some version of these.
>>
> This set of patches has been applied as b0d81ad but patch 0001 did not make
> it in, so pg_controldata is not yet able to accept -D:
> $ pg_controldata -D /foo/path
> pg_controldata: could not open file "-D/global/pg_control" for reading: No
> such file or directory
> $ pg_controldata /foo/path
> pg_controldata: could not open file "/foo/path/global/pg_control" for
> reading: No such file or directory
Argh, looks like I forgot the actual code changes required.
I just noticed that pg_controldata and pg_resetxlog don't check for
extra arguments:
$ pg_resetxlog data fds sdf sdf
Transaction log reset
Fixed that too.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-10-24 16:42:15 | Re: Question about RI checks |
| Previous Message | Robert Haas | 2014-10-24 16:07:42 | Re: Reducing lock strength of adding foreign keys |