Re: CREATE INDEX CONCURRENTLY on partitioned index

Ilya Gladyshev писал(а) 2024-07-13 01:17:
> On 12.07.2024 01:01, Michael Paquier wrote:
>
>> Please let's move this point to its own thread and deal with it with
>> an independent patch. Hiding that in a thread that's already quite
>> long is not a good idea. This needs proper review, and a separate
>> thread with a good subject to describe the problem will attract a
>> better audience to deal with the problem you are seeing.
>>
>> I was not paying much attention, until you've mentioned that this
>> was
>> an issue with HEAD.
>> --
>> Michael
>
> Sure, created a separate thread [1]. Please disregard the second patch
> in this thread. Duplicating the last version of the relevant patch
> here to avoid any confusion.
>
> [1]
> https://www.postgresql.org/message-id/b72f2d89-820a-4fa2-9058-b155cf646f4f%40gmail.com

Hi. We've found an issue with this patch. CIC can pop last active
snapshot when operating on partitioned table without leaves. This seems
to be similar to the issue, fixed by

commit c426f7c2b36a5efd9bcef2a2dfcc559f7879cd84
Author: Michael Paquier <michael(at)paquier(dot)xyz>
Date: Thu Dec 7 08:31:02 2023 +0900

Fix assertion failure with REINDEX and event triggers

Attaching rebased patch with the fix.
--
Best regards,
Alexander Pyhalov,
Postgres Professional