Re: pgsql: Fix snapshot reference leak if lo_export fails.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix snapshot reference leak if lo_export fails.
Date: 2021-11-04 16:31:05
Message-ID: 5430d13d-baf6-a3d5-3ed8-e22056855068@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 11/3/21 13:47, Heikki Linnakangas wrote:
> On 03/11/2021 13:06, Daniel Gustafsson wrote:
>>> On 3 Nov 2021, at 10:44, Heikki Linnakangas
>>> <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>>
>>> Fix snapshot reference leak if lo_export fails.
>>
>> This commit seems to lack the update in largeobject_1 as per hamerkop
>> in:
>
> Fixed, thanks!
>
> I'm a bit surprised none of the other Windows systems on the buildfarm
> complained. The difference in largeobject_1 output is apparently that
> the 'tenk.data' file uses Windows line endings. I guess that on all
> the other Windows hosts, git has been configured to use Unix line
> endings.

no, on drongo this comes up blank:

    git config --get --show-origin core.eol

These days I often set:

    git config --system core.eol lf
    git config --system core.autocrlf input

because it makes repos checked out with Windows native git work nicely
with msys git, but I haven't done that on drongo.

cheers

andrew

--

Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-11-05 00:13:50 Re: pgsql: Fix WAL replay in presence of an incomplete record
Previous Message Michael Paquier 2021-11-04 03:45:47 pgsql: Fix some thinkos with pg_receivewal --compression-method