| From: | Marko Tiikkaja <marko(at)joh(dot)to> |
|---|---|
| To: | Dmitriy Igrishin <dmitigr(at)gmail(dot)com>, Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: libpq connection status and closed fd |
| Date: | 2014-09-22 08:36:26 |
| Message-ID: | 541FDF8A.8000403@joh.to |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/22/14 9:45 AM, Dmitriy Igrishin wrote:
> 2014-09-22 11:35 GMT+04:00 Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>:
>
>> On Mon, Sep 22, 2014 at 8:17 AM, Dmitriy Igrishin <dmitigr(at)gmail(dot)com>
>> wrote:
>>> Why are you using close() instead of PQfinish()?
>>
>> Because I'm testing for an error, please read my message and the
>> original bug report.
>>
> I read it. You are testing for an error, but use libpq in a wrong way in
> your test case. You must use PQfinish() to close the connection
> and PQstatus() will works for you.
Perhaps you should go back and re-read it then. The point of the test
case is not to test connection closure; it's to test behaviour in the
presence of network errors.
.marko
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitriy Igrishin | 2014-09-22 08:45:51 | Re: libpq connection status and closed fd |
| Previous Message | Dmitriy Igrishin | 2014-09-22 07:45:34 | Re: libpq connection status and closed fd |