| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: Out-of-memory error reports in libpq |
| Date: | 2021-07-28 02:31:25 |
| Message-ID: | 541423.1627439485@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Bossart, Nathan" <bossartn(at)amazon(dot)com> writes:
> - appendPQExpBuffer(&conn->errorMessage,
> - libpq_gettext("out of memory allocating GSSAPI buffer (%d)\n"),
> - payloadlen);
> + pqReportOOM(conn);
> I see that some context is lost in a few places (e.g., the one above
> points to a GSSAPI buffer). Perhaps this extra context could be
> useful to identify problematic areas, but it might be unlikely to help
> much in these parts of libpq. In any case, the vast majority of
> existing callers don't provide any extra context.
Yeah, there are half a dozen places that currently print something
more specific than "out of memory". I judged that the value of this
was not worth the complexity it'd add to support it in this scheme.
Different opinions welcome of course.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-07-28 02:39:28 | Re: Slim down integer formatting |
| Previous Message | David Fetter | 2021-07-28 02:25:43 | Re: Slim down integer formatting |