| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, petr(dot)jelinek(at)2ndquadrant(dot)com |
| Cc: | noriyoshi(dot)shinoda(at)hpe(dot)com, pgsql-hackers(at)postgresql(dot)org, craig(at)2ndquadrant(dot)com |
| Subject: | Re: Logical Replication and Character encoding |
| Date: | 2017-04-05 15:33:51 |
| Message-ID: | 5401fef6-c0c0-7e8a-d8b1-169e30cbd854@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
After further thinking, I prefer the alternative approach of using
pq_sendcountedtext() as is and sticking the trailing zero byte on on the
receiving side. This is a more localized change, and keeps the logical
replication protocol consistent with the main FE/BE protocol. (Also, we
don't need to send a useless byte around.)
Patch attached, and also a test case.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-logical-replication-between-different-encodings.patch | invalid/octet-stream | 2.9 KB |
| 0002-Add-test-for-logical-replication-with-different-enco.patch | invalid/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2017-04-05 15:48:56 | Re: Quorum commit for multiple synchronous replication. |
| Previous Message | Joe Conway | 2017-04-05 15:31:43 | Re: partitioned tables and contrib/sepgsql |