| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(at)vondra(dot)me>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Documenting coding style |
| Date: | 2026-04-10 14:45:44 |
| Message-ID: | 53d971b5-8022-46df-a15e-084ed30c2d8e@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-04-10 Fr 10:17 AM, Andres Freund wrote:
> Hi,
>
> On April 10, 2026 3:57:56 AM EDT, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> Nitpicking code review for commit b15c1513:
>>
>> +read_archive_wal_page(XLogDumpPrivate *privateInfo, XLogRecPtr targetPagePtr,
>> + Size count, char *readBuff)
>>
>> I thought we agreed to stop using Size for new code? size_t has been
>> around since C89.
> We really need to start documenting some of this stuff somewhere. Deciding something a few years ago, deep in a thread, won't actually help anyone but the participants (and maybe not even them) to know about it.
>
> I wonder if we should move the coding style section out of sgml into a top-level CODING_STYLE.md or something like that.
>
> And then obviously add things like Size being deprecated.
>
+many. Great idea.
cheers
andew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-04-10 14:46:39 | Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid |
| Previous Message | Richard Guo | 2026-04-10 14:38:50 | Re: pg17: XX000: no relation entry for relid 0 |