| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | solai v <solai(dot)cdac(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, nagata(at)sraoss(dot)co(dot)jp |
| Subject: | Re: Why is the LSN reported for pg_logical_emit_message() different from other decoded operations? |
| Date: | 2026-08-10 07:25:17 |
| Message-ID: | 53d78c214c232d4813bbf032e2c952dc@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-07-21 18:57, solai v wrote:
> Thank you for the patch. I reviewed and tested this patch on my
> PostgreSQL 19beta2 tree. The patch did not apply cleanly on my branch
> because of a context mismatch in
> src/test/subscription/t/020_messages.pl.
Sorry for the late reply, and thanks for testing the patch.
Just to clarify, I tried applying v2 directly to the REL_19_BETA2 tag
(7873db5369b),
and git apply succeeded without any conflicts, including the change to
src/test/subscription/t/020_messages.pl.
I also checked whether that file differs between REL_19_BETA2 and
master, but found no differences:
$ git diff REL_19_BETA2 master --
src/test/subscription/t/020_messages.pl
$
The same is true for REL_19_STABLE and master:
$ git diff REL_19_STABLE master --
src/test/subscription/t/020_messages.pl
$
So I am not sure what caused the context mismatch.
Separately, I proposed fixing the issue in minor releases, but the v2
patch does not apply cleanly to 14 and 15.
Attached a patch for these versions.
--
Thanks,
--
Atsushi Torikoshi
Seconded from NTT DATA CORPORATION to SRA OSS K.K.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-LSN-of-logical-decoding-message-REL_14-15_STABLE.txt | text/x-diff | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-08-10 07:28:27 | Re: Fix detection of truncated zstd-compressed backups |
| Previous Message | Kirill Reshke | 2026-08-10 07:03:04 | check_circularity does not prevent from creating circular grants |