Re: Convert sepgsql tests to TAP

On 28.01.25 14:34, Dagfinn Ilmari Mannsåker wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> On 27.08.24 10:12, Peter Eisentraut wrote:
>>> Here is a new patch version.
>>> I simplified the uses of sed and awk inside the Perl script.  I also
>>> fixed "make installcheck".  I noticed that meson installs sepgsql.sql
>>> into the wrong directory, so that's fixed also.  (Many of the
>>> complications in this patch set are because sepgsql is not an
>>> extension but a loose SQL script, of which it is now the only one.
>>> Maybe something to address separately.)
>>> I did end up deciding to keep the old test_sepgsql script, because it
>>> does have the documented purpose of testing existing installations.  I
>>> did change it so that it calls pg_regress directly, without going via
>>> make, so that the dependency on make is removed.
>>
>> This has been committed. And I understand there is a buildfarm client
>> update available for the affected buildfarm members.
>
> This patch passed the TAP command invocation cleanup patch mid-flight,
> so didn't get the memo about command usng the fat comma for line option
> arguments. Here's a patch for bringing it in line with the new
> convention. I don't have any machines with SELinux enabled, so either
> someone who has would need to test it, or we can rely on the buildfarm.

committed, thanks!