Re: Unwanted LOG during recovery of DROP TABLESPACE REDO

On 08/15/2014 12:31 PM, Marko Tiikkaja wrote:
> On 7/16/14 4:33 PM, Tom Lane wrote:
>> Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> writes:
>>> I found and fixed a bug that causes recovery (crash recovery , PITR) to throw unwanted LOG message if the tablespace symlink is not found during the processing of DROP TABLESPACE redo.
>>> LOG: could not remove symbolic link "pg_tblspc/16384": No such file or directory
>>
>> I don't think that's a bug: it's the designed behavior. Why should we
>> complicate the code to not print a log message in a situation where
>> it's unclear if the case is expected or not?
>
> I agree with Tom here; this doesn't seem like an improvement.

Well, for comparison, we also silently ignore non-existent files when
replaying a "DROP TABLE". I could go either way myself, but this is
clearly a very minor thing, and we have two -1's, so I'm marking this as
"Rejected" in the commitfest.

Thanks anyway!

- Heikki