| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Martijn van Oosterhout <kleptog(at)svana(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Supporting Windows SChannel as OpenSSL replacement |
| Date: | 2014-08-01 17:40:25 |
| Message-ID: | 53DBD109.5020907@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/27/2014 02:26 AM, Andreas Karlsson wrote:
> On 06/24/2014 03:20 AM, Jeff Janes wrote:
>> I've tried your 0001 patch, reflecting this refactoring, on Linux and it
>> caused 'make check' to hang at 'starting postmaster'.
>
> I found the bug in the code, and I have attached the a patch which you
> can apply on top of the patch. The regression tests pass now on my
> Debian machine.
Ah, thanks!
> One thing I noticed when trying to find the bug is that be-secure.c
> still includes some OpenSSL headers. Those should be removed since they
> have already been moved to be-secure-openssl.c.
Removed.
Here's a new version of the patch, rebased over master and those two
things fixed.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Invent-a-new-internal-API-for-interfacing-with-SSL-2.patch | text/x-diff | 159.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-08-01 17:52:51 | Re: Supporting Windows SChannel as OpenSSL replacement |
| Previous Message | Claudio Freire | 2014-08-01 17:05:21 | Re: Proposal: Incremental Backup |