From: | Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz> |
---|---|
To: | John Cochran <j69cochran(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Proposal for updating src/timezone |
Date: | 2014-07-20 00:08:50 |
Message-ID: | 53CB0892.9010503@archidevsys.co.nz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 20/07/14 06:30, John Cochran wrote:
>
>
>
> On Sat, Jul 19, 2014 at 11:58 AM, Michael Banck <mbanck(at)gmx(dot)net
> <mailto:mbanck(at)gmx(dot)net>> wrote:
> SNIP
>
> Maybe if you pgindent the IANA code as well, you can more easily diff
> the actual changes between the two, did you try that?
>
>
> Michael
>
>
> Unfortunately, pgindent doesn't work well with the IANA code as
> evident by some previous checkins.
>
> To quote a checkin done 2004-05-21 16:59:10 by Tom Lane
> pgindent did a pretty awful job on the timezone code, particularly
> with respect to doubly-starred comment blocks. Do some manual cleanup.
>
[...]
For simply noting functional differences: could not make copies of the
sources files for both the pg & IANA code, and remove ALL indentation
prior to to a a diff?
Cheers,
Gavin
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2014-07-20 02:04:32 | Re: Making joins involving ctid work for the benefit of UPSERT |
Previous Message | Tomas Vondra | 2014-07-19 22:12:56 | Re: tweaking NTUP_PER_BUCKET |