| From: | Mohammad Alhashash <alhashash(at)alhashash(dot)net> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PATCH: Allow empty targets in unaccent dictionary |
| Date: | 2014-06-29 12:03:10 |
| Message-ID: | 53B0007E.70104@alhashash.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thanks a lot for the review and comments. Here is an updated patch.
On 6/25/2014 8:20 AM, Abhijit Menon-Sen wrote:
> Your patch should definitely add a test case or two to
> sql/unaccent.sql and expected/unaccent.out showing the behaviour that
> didn't work before the change.
That would require adding new entries to the "unaccent.rules" template.
I'm afraid that the templates I'm using for Arabic now are not complete
enough to be including in the default dictionary.
I can create a new template just for the test cases but I've to update
the make file to include that file in installation. Should I do this?
Thanks,
Mohammad Alhashash
| Attachment | Content-Type | Size |
|---|---|---|
| unaccent.patch | text/plain | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-06-29 12:25:44 | Re: Cluster name in ps output |
| Previous Message | Abhijit Menon-Sen | 2014-06-29 11:43:28 | Re: PATCH: Allow empty targets in unaccent dictionary |