Re: What's the point of json_extract_path_op etc?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: What's the point of json_extract_path_op etc?
Date: 2014-06-26 21:27:38
Message-ID: 53AC904A.20803@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 06/26/2014 03:11 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 06/25/2014 02:46 PM, Tom Lane wrote:
>>> Why do we have essentially duplicate pg_proc entries for json_extract_path
>>> and json_extract_path_op?
>>> Likewise for json_extract_path_text_op, jsonb_extract_path_op, and
>>> jsonb_extract_path_text_op.
>> ISTR trying that and running into problems, maybe with opr_sanity checks.
> Well, the reason that opr_sanity is complaining is that there's a
> violation of our general policy of documenting either the operator or
> the underlying function, not both. Using a separate pg_proc entry
> like this doesn't mean you didn't violate the policy; you just hid the
> violation from opr_sanity.
>
> Do we actually want to document these things as both operators and
> functions? If we do, then the right answer is to list them as known
> exceptions in the opr_sanity test, not to hide the fact that we're
> violating the general documentation policy.

It's quite important that we have the variadic functions exposed.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-06-26 21:30:04 Re: Spinlocks and compiler/memory barriers
Previous Message Jeff Janes 2014-06-26 21:27:23 Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]