Re: releaseOk and LWLockWaitForVar

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: <heikki(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: releaseOk and LWLockWaitForVar
Date: 2014-06-23 16:40:00
Message-ID: 53A85860.2020400@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/23/2014 05:38 PM, Amit Kapila wrote:
> While looking at function LWLockWaitForVar(), espacially below
> code:
>
> TRACE_POSTGRESQL_LWLOCK_ACQUIRE(T_NAME(l), T_ID(l), LW_EXCLUSIVE);
>
> I think in this function tracing is done considering the Exclusive lock
> is acquired, however it might have granted access because of
> variable updation. Basically this function's trace doesn't distinguish
> whether the access is granted due to the reason that there is no other
> exclusive locker or variable is updated.

Yeah. Not sure it's worth it to add new TRACE points for this, I'm not
really familiar with the way the traces work or how people use them.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2014-06-23 16:45:57 Re: SQL access to database attributes
Previous Message Vik Fearing 2014-06-23 16:39:50 Re: SQL access to database attributes