Re: wrapping in extended mode doesn't work well with default pager

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Noah Misch <noah(at)leadboat(dot)com>, Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wrapping in extended mode doesn't work well with default pager
Date: 2014-06-11 18:52:09
Message-ID: 5398A559.7080309@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/8/14, 11:29 PM, Noah Misch wrote:
> The patch did not restore 9.3 behavior for that one. Starting with commit
> 6513633, the first line of letters is space-padded on the right to the width
> of the second line of letters. To illustrate, I have attached raw psql output
> from both commit 6513633 and its predecessor. Also note that
> psql-wrapped-expanded-fix-v4.patch expands each [ RECORD x ] header from 509
> bytes to 511 bytes; 509 is the longstanding width.

I noticed that (or perhaps a related) problem today. Here is a simple demo:

psql -X -q -t -x -c 'select * from (values (1),(2)) as _ (col)'

9.3:

col | 1
----+--
col | 2

9.4:

col | 1
----+--
col | 2

This breaks check_postgres. (Why check_postgres doesn't use unaligned
output is beyond me.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-06-11 19:26:54 Re: API change advice: Passing plan invalidation info from the rewriter into the planner?
Previous Message Tom Lane 2014-06-11 18:47:10 Re: API change advice: Passing plan invalidation info from the rewriter into the planner?