Re: coverage additions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: coverage additions
Date: 2019-05-30 18:05:17
Message-ID: 53966.1559239517@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> I just enabled --enabled-llvm on the coverage reporting machine, which
> made src/backend/jit/jit.c go from 60/71 % (line/function wise) to 78/85 % ...
> and src/backend/jit/llvm from not appearing at all in the report to
> 78/94 %. That's a good improvement.

> If there are other obvious improvements to be had, please let me know.

I was going to suggest that adding some or all of

-DCOPY_PARSE_PLAN_TREES
-DWRITE_READ_PARSE_PLAN_TREES
-DRAW_EXPRESSION_COVERAGE_TEST

to your CPPFLAGS might improve the reported coverage in backend/nodes/,
and perhaps other places.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-05-30 18:10:33 Re: New committer: David Rowley
Previous Message Tom Lane 2019-05-30 18:01:00 tableam.h fails cpluspluscheck