tableam.h fails cpluspluscheck

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: tableam.h fails cpluspluscheck
Date: 2019-05-30 18:01:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Using Apple's clang as c++ compiler:

In file included from /tmp/cpluspluscheck.KejiIw/test.cpp:3:
./src/include/access/tableam.h:144:16: error: typedef redefinition with different types ('void (*)(Relation, HeapTuple, Datum *, bool *, bool, void *)' (aka 'void (*)(RelationData *, HeapTupleData *, unsigned long *, bool *, bool, void *)') vs 'IndexBuildCallback')
typedef void (*IndexBuildCallback) (Relation index,
./src/include/access/tableam.h:36:8: note: previous definition is here
struct IndexBuildCallback;

(there are some cascading errors, but this is the important one)

Kinda looks like you can't get away with using "struct" on a forward
declaration of something that is not actually a struct type.

regards, tom lane


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-05-30 18:05:17 Re: coverage additions
Previous Message Alvaro Herrera 2019-05-30 17:52:20 coverage additions