Re: Support for NSS as a libpq TLS backend

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "andrew(dot)dunstan(at)2ndquadrant(dot)com" <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "thomas(dot)munro(at)gmail(dot)com" <thomas(dot)munro(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>
Subject: Re: Support for NSS as a libpq TLS backend
Date: 2021-02-08 23:08:37
Message-ID: 5382CB4A-9CF3-4145-BA46-C802615935E0@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Feb 2021, at 08:30, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> Could it be possible to split 0001 into two parts at least with one
> patch that includes the basic changes for the build and ./configure,
> and a second with the FE/BE changes?

Attached is a new patchset where I've tried to split the patches even further
to try and separate out changes for easier review. While not a perfect split
I'm sure, and clearly only for review purposes, I do hope it helps a little.
There is one hunk in 0002 which moves some OpenSSL specific code from
underneath USE_SSL, but thats about the only non-NSS change left in this
patchset AFAICS.

Additionally, this version moves the code in thee shared header to a proper .c
file shared between frontend and backend as well as performs some general
cleanup around that.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
v26-0010-nss-Build-infrastructure.patch application/octet-stream 20.0 KB
v26-0009-nss-Support-NSS-in-cryptohash.patch application/octet-stream 5.7 KB
v26-0008-nss-Support-NSS-in-sslinfo.patch application/octet-stream 3.6 KB
v26-0007-nss-Support-NSS-in-pgcrypto.patch application/octet-stream 24.6 KB
v26-0006-nss-Documentation.patch application/octet-stream 20.0 KB
v26-0005-nss-pg_strong_random-support.patch application/octet-stream 1.9 KB
v26-0004-nss-Add-NSS-specific-tests.patch application/octet-stream 43.9 KB
v26-0003-Refactor-SSL-testharness-for-multiple-library.patch application/octet-stream 11.2 KB
v26-0002-nss-Remove-mentions-and-infra-of-OpenSSL-being-t.patch application/octet-stream 3.8 KB
v26-0001-nss-Support-libnss-as-TLS-library-in-libpq.patch application/octet-stream 90.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-02-08 23:11:05 Re: Support for NSS as a libpq TLS backend
Previous Message Jonathan S. Katz 2021-02-08 22:40:41 2021-02-11 release announcement draft