Re: PATCH: pgbench / int64 instead of int for xact count

From: Tomas Vondra <tv(at)fuzzy(dot)cz>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: pgbench / int64 instead of int for xact count
Date: 2014-05-25 18:25:19
Message-ID: 5382358F.9040700@fuzzy.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25.5.2014 19:05, Andres Freund wrote:
>> printf("number of transactions per client: %d\n", nxacts);
>> - printf("number of transactions actually processed: %d/%d\n",
>> + printf("number of transactions actually processed: %ld/%d\n",
>> normal_xacts, nxacts * nclients);
>
> That's not right though. On windows a long (indicated by the %l) is only
> 4 bytes wide. Check INT64_FORMAT. That's generated by configure/platform
> template files and should always be correct.

Oh, right. v2 of the patch attached.

Tomas

Attachment Content-Type Size
pgbench-int64-v2.patch text/x-diff 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-05-25 18:32:51 Re: PATCH: pgbench / int64 instead of int for xact count
Previous Message Tom Lane 2014-05-25 18:16:46 Re: [9.5] possible fast path for pinning a page multiple times