Re: Minor improvement to fdwhandler.sgml

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor improvement to fdwhandler.sgml
Date: 2014-05-08 02:40:55
Message-ID: 536AEEB7.3000302@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2014/05/05 23:05), Robert Haas wrote:
> On Wed, Apr 30, 2014 at 4:10 AM, Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> (2014/04/28 23:31), Robert Haas wrote:
>>> On Thu, Apr 24, 2014 at 7:59 AM, Etsuro Fujita
>>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>>
>>>> The patch attached improves docs in fdwhandler.sgml a little bit.
>>>
>>>
>>> When you submit a patch, it's helpful to describe what the patch
>>> actually does, rather than just saying it makes things better. For
>>> example, I think that this patch could be described as "in
>>> fdwhandler.sgml, mark references to scan_clauses with <structfield>
>>> tags".
>>
>>
>> I thought so. Sorry, my explanation wasn't enough.
>>
>>
>>> A problem with that idea is that scan_clauses is not a field in any
>>> struct.
>>
>>
>> I was mistaken. I think those should be marked with <literal> tags. Patch
>> attached.
>
> OK, committed.

Thanks!

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-05-08 02:44:57 Re: Wanted: jsonb on-disk representation documentation
Previous Message Stephen Frost 2014-05-08 02:36:23 Re: [v9.5] Custom Plan API