Re: Fix initdb for path with whitespace and at char

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nikhil Deshpande <nikhail(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix initdb for path with whitespace and at char
Date: 2014-04-30 19:03:06
Message-ID: 536148EA.1000400@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 04/30/2014 11:58 AM, Andrew Dunstan wrote:
>
> On 04/30/2014 06:31 AM, Heikki Linnakangas wrote:
>>
>>
>>
>> Andrew: you have a cygwin installation, don't you? Could you test if
>> "pg_ctl start" works when the binaries are installed to a path that
>> contains both a space and an @ sign, like "C:\white
>> space\at(at)sign\install". I suspect it doesn't, but the attached patch
>> fixes it.
>>
>>
>
>
> I'll see what I can do.

I tried git master like this:

foo\ bar/a\(at)b/bin/initdb.exe data
foo\ bar/a\(at)b/bin/pg_ctl.exe -D data/ -w start

and didn't encounter a problem.

Platform is Windows 8 Pro 64 bit, with latest 32 bit Cygwin.

[ ... ] It looks like possibly the only time this will actually matter
on Cygwin is when starting a service. Just running "pg_ctl start" from
the command line works fine. But starting the service doesn't.

I'll try the patch when I get a chance.

cheers

andrew

>
> cheers
>
> andrew
>
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2014-04-30 19:16:53 Re: GSoC on WAL-logging hash indexes
Previous Message Peter Geoghegan 2014-04-30 18:19:33 Re: GSoC on WAL-logging hash indexes