| From: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
|---|---|
| To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Bug in GiST paring heap comparator |
| Date: | 2019-09-24 22:19:52 |
| Message-ID: | 53536807-784c-e029-6e92-6da802ab8d60@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.09.2019 0:15, Nikita Glukhov wrote:
> On 19.09.2019 22:14, Alexander Korotkov wrote:
>> Pushed.
> Attached patch fixes premature xs_orderbynulls[] assignment. The old value
> of NULL flag, not the new, should be checked before pfree()ing the old value.
Attached another one-line patch that fixes incorrect number of distances used
in pairingheap_SpGistSearchItem_cmp():
- for (i = 0; i < so->numberOfOrderBys; i++)
+ for (i = 0; i < so->numberOfNonNullOrderBys; i++)
This change was present in my original commit, but it seems to have been
missed after the rebase. Sorry.
--
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-number-of-distances-in-pairingheap_SpGistSearchI.patch | text/x-patch | 878 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ziga | 2019-09-24 22:41:53 | Re: DROP SUBSCRIPTION with no slot |
| Previous Message | Tom Lane | 2019-09-24 22:09:28 | Re: allocation limit for encoding conversion |