| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Only first XLogRecData is visible to rm_desc with WAL_DEBUG |
| Date: | 2014-03-26 16:29:04 |
| Message-ID: | 53330050.4020200@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/26/2014 04:51 PM, Robert Haas wrote:
> On Wed, Mar 26, 2014 at 5:08 AM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> Oh, no, there's no need to do it while holding WALInsertLock. It's quite
>> trivial, actually, see attached. So it's not difficult to fix this if we
>> want to.
>
> Well is there any reason not to just commit that patch? I mean, it
> seems odd to rip this out if the fix is straightforward and already
> written.
I guess so. Committed..
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ants Aasma | 2014-03-26 16:29:38 | Missing pfree in logical_heap_rewrite_flush_mappings() |
| Previous Message | Bruce Momjian | 2014-03-26 16:10:56 | Re: Useless "Replica Identity: NOTHING" noise from psql \d |