| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to> |
| Subject: | Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors |
| Date: | 2014-03-23 14:53:59 |
| Message-ID: | 532EF587.20705@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23/03/14 15:14, Pavel Stehule wrote:
> Review shadow_v6 patch
>
> I have only one objection - What I remember - more usual is using a list
> instead a bitmap for these purposes - typical is DefElem struct. Isn't
> it better?
>
To me it seemed that for similar use cases (list of boolean options) the
bitmap is more common in the existing code, question might be if we go
over the 32 bits any time soon which does not seem likely to me for the
checks.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2014-03-23 15:03:19 | Re: psql blows up on BOM character sequence |
| Previous Message | Pavel Stehule | 2014-03-23 14:28:28 | Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors |