Re: pg_archivecleanup bug

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_archivecleanup bug
Date: 2014-03-18 19:13:28
Message-ID: 53289AD8.4060204@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/18/2014 09:04 PM, Simon Riggs wrote:
> On 18 March 2014 18:55, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> That said, I don't find comma expression to be particularly "not
>> simple".
>
> Maybe, but we've not used it before anywhere in Postgres, so I don't
> see a reason to start now. Especially since C is not the native
> language of many people these days and people just won't understand
> it.

Agreed. The psqlODBC code is littered with comma expressions, and the
first time I saw it, it took me a really long time to figure out what
"if (foo = malloc(...), foo) { } " meant. And I consider myself quite
experienced with C.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-03-18 19:14:42 Re: plpgsql.warn_shadow
Previous Message Josh Berkus 2014-03-18 19:13:12 Re: GSoC proposal. Index-only scans for GIST