Re: backend crash on DELETE, reproducible locally

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Ondřej Bouda <obouda(at)email(dot)cz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, pgsql-general(at)lists(dot)postgresql(dot)org
Subject: Re: backend crash on DELETE, reproducible locally
Date: 2018-11-06 22:11:40
Message-ID: 5323.1541542300@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-11-06 16:47:20 -0500, Tom Lane wrote:
>> Looks like somebody forgot to list
>> RELOPT_KIND_GIST in RELOPT_KIND_INDEX, but is that the
>> fault of commit c203d6cf8 or was it busted before?

> Looks new:
> + RELOPT_KIND_INDEX = RELOPT_KIND_BTREE|RELOPT_KIND_HASH|RELOPT_KIND_GIN|RELOPT_KIND_SPGIST,
> there aren't any other "for all indexes" type options, so the whole
> category didn't exist before.

> It also strikes me as a really bad idea, even if RELOPT_KIND_GIST
> wouldn't have been omitted: It breaks index am extensibility.

Hm, well, that enum already knows about all index types, doesn't it?

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Andres Freund 2018-11-06 22:16:36 Re: backend crash on DELETE, reproducible locally
Previous Message Tomas Vondra 2018-11-06 22:11:29 Re: backend crash on DELETE, reproducible locally

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-11-06 22:16:36 Re: backend crash on DELETE, reproducible locally
Previous Message Tomas Vondra 2018-11-06 22:11:29 Re: backend crash on DELETE, reproducible locally