| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | japin <japinli(at)hotmail(dot)com> |
| Cc: | "Michael Paquier" <michael(at)paquier(dot)xyz>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, "David Steele" <david(at)pgmasters(dot)net>, "Craig Ringer" <craig(at)2ndquadrant(dot)com>, "Tomas Vondra" <tomas(dot)vondra(at)2ndquadrant(dot)com>, "Amit Langote" <amitlangote09(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: row filtering for logical replication |
| Date: | 2021-02-02 12:34:34 |
| Message-ID: | 52edc9d2-8e52-4cde-9a15-991961b78387@www.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 2, 2021, at 8:38 AM, japin wrote:
> In 0003 patch, function GetPublicationRelationQuals() has been defined, but it
> never used. So why should we define it?
Thanks for taking a look again. It is an oversight. It was introduced in an
attempt to refactor ALTER PUBLICATION SET TABLE. In AlterPublicationTables, we
could possibly keep some publication-table mappings that does not change,
however, since commit 3696a600e2, it is required to find the qual for all
inheritors (see GetPublicationRelations). I explain this decision in the
following comment:
/*
* Remove all publication-table mappings. We could possibly
* remove (i) tables that are not found in the new table list and
* (ii) tables that are being re-added with a different qual
* expression. For (ii), simply updating the existing tuple is not
* enough, because of qual expression dependencies.
*/
I will post a new patch set later.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-02-02 12:50:42 | Re: [PATCH] Doc: improve documentation of oid columns that can be zero. (correct version) |
| Previous Message | Heikki Linnakangas | 2021-02-02 12:26:33 | Re: Improve new hash partition bound check error messages |