Re: pg_upgrade fails with non-standard ACL

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails with non-standard ACL
Date: 2019-10-28 14:40:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

08.10.2019 17:08, Stephen Frost wrote:
>> I attached the updated version. Now it prints a better error message
>> and generates an SQL script instead of multiple warnings. The attached test
>> script shows that.
> Have you tested this with extensions, where the user has changed the
> privileges on the extension? I'm concerned that we'll throw out
> warnings and tell users to go REVOKE privileges on any case where the
> privileges on an extension's object were changed, but that shouldn't be
> necessary and we should be excluding those.
Good catch.
Fixed in v3.

I also added this check to previous test script. It passes with both v2
and v3,
but v3 doesn't throw unneeded warning for extension functions.

> Changes to privileges on extensions should be handled just fine using
> the existing code, at least for upgrades of PG.
> Otherwise, at least imv, the code could use more comments (inside the
> functions, not just function-level...) and there's a few wording
> improvements that could be made. Again, not a full endorsement, as I
> just took a quick look, but it generally seems like a reasonable
> approach to go in and the issue with extensions was the only thing that
> came to mind as a potential problem.
I added more comments and updated the error message.
Please, feel free to fix them, if you have any suggestions.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
pg_upgrade_ACL_check_v3_master.patch text/x-patch 8.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-10-28 14:41:31 Re: Proposition to use '==' as synonym for 'IS NOT DISTINCT FROM'
Previous Message william allen 2019-10-28 14:28:59 RE: BUG #15858: could not stat file - over 4GB