| From: | "Albe Laurenz" <all(at)adv(dot)magwien(dot)gv(dot)at> |
|---|---|
| To: | "Bruce Momjian *EXTERN*" <bruce(at)momjian(dot)us> |
| Cc: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: LDAP lookup of connection parameters |
| Date: | 2006-07-27 12:57:39 |
| Message-ID: | 52EF20B2E3209443BC37736D00C3C13809A923B9@EXADV1.host.magwien.gv.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Bruce Momjian wrote:
>>>> This patch for libpq allows you to enter an LDAP URL in
>>>> pg_service.conf.
>>>> The URL will be queried and the resulting string(s) parsed for
>>>> keyword = value connection options.
>>>
>>> I have heavily modified your patch to be clearer. Please
>>> review the
>>> attached version and test it to make sure it still works
>>> properly.
>
> Thanks for the review. Updated patch attached. Is that OK?
Mostly yes, and I must admit that the code has become more
readable. There were two syntax errors and some minor odds
and ends (partly my fault).
I have slightly changed your patch and submit it again
(diff the patches to see).
Thanks for the effort,
Laurenz Albe
| Attachment | Content-Type | Size |
|---|---|---|
| ldap_v2.patch | application/octet-stream | 16.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2006-07-27 13:08:52 | WAL file rotation/ XLog Switch |
| Previous Message | Tom Lane | 2006-07-27 12:30:21 | Re: extension for sql update |