Re: CREATE TABLESPACE WITH

On 1/14/14, 8:07 PM, Michael Paquier wrote:
> On Wed, Jan 15, 2014 at 10:27 AM, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> wrote:
>> On 12/26/2013 06:10 PM, David Fetter wrote:
>>> On Tue, Dec 24, 2013 at 07:25:01PM +0100, Vik Fearing wrote:
>>>> I was recently annoyed that I had to do
>>>>
>>>> CREATE TABLESPACE x LOCATION y;
>>>> ALTER TABLESPACE x SET (random_page_cost = z);
>>>>
>>>> The attached patch is a quick n' dirty extension to allow the SET
>>>> directly on the CREATE statement.
>>>>
>>>> CREATE TABLESPACE x LOCATION y SET (random_page_cost = z);
>>> That should probably be WITH instead of SET for consistency with other
>>> similar DDL.
>>
>> Here is version 2 of the patch, which uses WITH instead of SET, and also
>> adds to the documentation.
> I just had a quick look at this patch, no testing at all. I am seeing
> that regression tests are still missing here, they should be added in
> src/test/regress/input/tablespace.source. Then, for the use of either
> WITH or SET... For example CREATE FUNCTION uses SET for a
> configuration parameter, and ALTER FUNCTION is consistent with that.
> So SET makes more sense to be consistent with CREATE TABLESPACE? This
> patch should not be modified once again as long as there are no more
> opinions though...

You know, this doesn't do much to encourage people to submit patches since it was just suggested that we use WITH instead of SET. :(

Anyone have an easy way to see which is more prevalent? I'd be stuck with \h or trying to grep SGML... I'm hoping someone else has an easier way...
--
Jim C. Nasby, Data Architect jim(at)nasby(dot)net
512.569.9461 (cell) http://jim.nasby.net