Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Antonin Houska <antonin(dot)houska(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Meskes <meskes(at)postgresql(dot)org>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
Subject: Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes
Date: 2013-12-06 13:01:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

2013-12-04 14:51 keltezéssel, Boszormenyi Zoltan írta:
> 2013-12-03 16:48 keltezéssel, Antonin Houska írta:
>> Tests - 23.patch
>> ----------------
>> src/interfaces/ecpg/test/sql/cursorsubxact.pgc
>> /*
>> * Test the implicit RELEASE SAVEPOINT if a SAVEPOINT
>> * is used with an already existing name.
>> */
>> Shouldn't it be "... if a CURSOR is used with an already existing
>> name?". Or just "... implicit RELEASE SAVEPOINT after an error"?
>> I'd also appreciate a comment where exactly the savepoint is
>> (implicitly) released.
> I have already answered this in my previous answer.

And I was wrong in that. The comments in the test were rearranged
a little and the fact in the above comment is now actually tested.

Some harmless unused variables were also removed and an
uninitialized variable usage was fixed. Because of these and the above
changes a lot of patches need to be rebased.

All patches are attached again for completeness.

Best regards,
Zoltán Böszörményi

Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria

Attachment Content-Type Size
09.patch text/x-patch 1.5 KB
10.patch text/x-patch 4.4 KB
11.patch text/x-patch 3.8 KB
12.patch text/x-patch 4.2 KB
13.patch.gz application/x-tar 4.7 KB
14.patch text/x-patch 4.5 KB
15.patch text/x-patch 8.1 KB
16.patch text/x-patch 5.1 KB
17.patch.gz application/x-tar 16.2 KB
18.patch text/x-patch 16.1 KB
19.patch text/x-patch 7.5 KB
20.patch text/x-patch 9.3 KB
21.patch text/x-patch 5.8 KB
22.patch text/x-patch 4.7 KB
23.patch.gz application/x-tar 22.8 KB
24.patch text/x-patch 7.8 KB
25.patch.gz application/x-tar 13.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Boszormenyi Zoltan 2013-12-06 13:05:03 Re: ECPG FETCH readahead, was: Re: ECPG fixes
Previous Message Fabrízio de Royes Mello 2013-12-06 12:15:27 Re: dblink performance regression