Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Antonin Houska <antonin(dot)houska(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Meskes <meskes(at)postgresql(dot)org>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
Subject: Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes
Date: 2013-12-04 13:51:19
Message-ID: 529F3357.7090103@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2013-12-03 16:48 keltezéssel, Antonin Houska írta:
> 22.patch
> --------
>
> tuples_left > 0
>
> instead of just
>
> tuples_left
>
> seems to me safer in for-loops. Not sure if there's a convention for
> this though.

I decided not to change this. The "tuples_left" variable starts at
a non-negative value and decreased by one in every iteration.
The previous code also used the same "test for non-zero" test with
the variable "ntuples".

> 23.patch
> --------
>
> git apply --verbose ~/cybertec/patches/ecpq/23.patch
> /home/anton/cybertec/patches/ecpq/23.patch:494: space before tab in indent.
> /*------
> /home/anton/cybertec/patches/ecpq/23.patch:495: space before tab in indent.
> translator: this string will be truncated at
> 149 characters expanded. */
> /home/anton/cybertec/patches/ecpq/23.patch:4019: trailing whitespace.
> exec sql close :curname;

I fixed this in this patch and all subsequent ones.

> Tests - 23.patch
> ----------------
>
> src/interfaces/ecpg/test/sql/cursorsubxact.pgc
>
>
> /*
> * Test the implicit RELEASE SAVEPOINT if a SAVEPOINT
> * is used with an already existing name.
> */
>
> Shouldn't it be "... if a CURSOR is used with an already existing
> name?". Or just "... implicit RELEASE SAVEPOINT after an error"?
> I'd also appreciate a comment where exactly the savepoint is
> (implicitly) released.

I have already answered this in my previous answer.

All patches are attached again for completeness.

> 23.patch and 24.patch
> ---------------------
>
> SO_MAJOR_VERSION and also interfaces/ecpg/include/ecpglib.h is changed
>
> Thus all client applications probably need to be preprocessed & compiled
> against the PG 9.4. I don't know how this is usually enforced. I'm
> mentioning it for the sake of completeness.
>
> // Antonin Houska (Tony)
>
>
> On 11/28/2013 03:21 PM, Boszormenyi Zoltan wrote:
>> 2013-11-20 14:53 keltezéssel, Boszormenyi Zoltan írta:
>>> 2013-11-20 14:41 keltezéssel, Boszormenyi Zoltan írta:
>>>> 2013-11-12 07:15 keltezéssel, Boszormenyi Zoltan írta:
>>>>> 2013-11-12 07:01 keltezéssel, Noah Misch írta:
>>>>>> On Mon, Nov 11, 2013 at 10:17:54AM +0100, Boszormenyi Zoltan wrote:
>>>>>>> The old contents of my GIT repository was removed so you need to
>>>>>>> clone it fresh. https://github.com/zboszor/ecpg-readahead.git
>>>>>>> I won't post the humongous patch again, since sending a 90KB
>>>>>>> compressed file to everyone on the list is rude.
>>>>>> Patches of that weight show up on a regular basis. I don't think it's rude.
>>>>> OK, here it is.
>>>> ...
>>>> Subsequent patches will come as reply to this email.
>>> Infrastructure changes in ecpglib/execute.c to split up
>>> ECPGdo and ecpg_execute() and expose the parts as
>>> functions internal to ecpglib.
>> Rebased after killing the patch that changed the DECLARE CURSOR command tag.
>> All infrastructure patches are attached, some of them compressed.
>>
>> Best regards,
>> Zoltán Böszörményi
>>
>>
>>
>>

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/

Attachment Content-Type Size
09.patch text/x-patch 1.5 KB
10.patch text/x-patch 4.4 KB
11.patch text/x-patch 3.8 KB
12.patch text/x-patch 4.2 KB
13.patch.gz application/x-tar 4.7 KB
14.patch text/x-patch 4.5 KB
15.patch text/x-patch 8.1 KB
16.patch text/x-patch 5.1 KB
17.patch.gz application/x-tar 16.2 KB
18.patch.gz application/x-tar 3.1 KB
19.patch text/x-patch 7.5 KB
20.patch text/x-patch 9.3 KB
21.patch text/x-patch 5.8 KB
22.patch text/x-patch 4.9 KB
23.patch.gz application/x-tar 22.3 KB
24.patch text/x-patch 7.8 KB
25.patch.gz application/x-tar 13.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Boszormenyi Zoltan 2013-12-04 13:52:57 Re: ECPG FETCH readahead, was: Re: ECPG fixes
Previous Message Mitsumasa KONDO 2013-12-04 13:47:47 Re: Time-Delayed Standbys