From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Fix whitespace issues found by git diff --check, add gitattribut |
Date: | 2013-11-11 19:17:08 |
Message-ID: | 52812D34.2010607@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 11/11/13, 10:26 AM, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Fix whitespace issues found by git diff --check, add gitattributes
>> Set per file type attributes in .gitattributes to fine-tune whitespace
>> checks. With the associated cleanups, the tree is now clean for git
>
> Hmm, I thought the .gitattributes file would prevent this:
>
> $ git diff --staged --check
> src/test/regress/expected/join.out:3110: trailing whitespace.
> + q1 | q2 | f1 | ff
>
> Is there something I have to do to configure git to honor the file?
>
> (In case it matters, this is git 1.7.1, which is what Red Hat is
> shipping these days in RHEL6.)
Older versions of git (before 1.8.2) do not support the "**" syntax used
here:
**/expected/*.out -whitespace
If we're slightly daring, we could change this to just
*.out -whitespace
and analogously for the other entries, but I haven't fully analyzed that.
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2013-11-11 19:38:49 | Re: Re: [COMMITTERS] pgsql: Fix whitespace issues found by git diff --check, add gitattribut |
Previous Message | Tom Lane | 2013-11-11 18:36:54 | pgsql: Fix ruleutils pretty-printing to not generate trailing whitespac |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2013-11-11 19:26:49 | Re: all_visible replay aborting due to uninitialized pages |
Previous Message | Andres Freund | 2013-11-11 19:06:58 | Re: logical changeset generation v6.5 |