Re: [PATCH] pg_receivexlog: fixed to work with logical segno > 0

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Mika Eloranta <mel(at)ohmu(dot)fi>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] pg_receivexlog: fixed to work with logical segno > 0
Date: 2013-11-04 09:06:49
Message-ID: 527763A9.3040302@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01.11.2013 11:42, Mika Eloranta wrote:
> pg_receivexlog calculated the xlog segment number incorrectly
> when started after the previous instance was interrupted.
>
> Resuming streaming only worked when the physical wal segment
> counter was zero, i.e. for the first 256 segments or so.

Oops. Fixed, thanks for the report!

It's a bit scary that this bug went unnoticed for this long; it was
introduced quite early in the 9.3 development cycle. Seems that I did
all the testing of streaming timeline changes with pg_receivexlog later
in 9.3 cycle with segment numbers < 256, and no-one else have done
long-running tests with pg_receivexlog either.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-11-04 09:35:23 Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry?
Previous Message Craig Ringer 2013-11-04 08:31:27 What stopped SECURITY BARRIER views from being auto-updatable?