From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: split func.sgml to separated individual sgml files |
Date: | 2025-09-30 20:15:32 |
Message-ID: | 527282.1759263332@sss.pgh.pa.us |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2025-09-12 Fr 10:12 AM, Nazir Bilal Yavuz wrote:
>> Test's name is 'sgml_syntax_check' in the Meson. One difference I
>> noticed: I could not find a way in Meson to create a test that does
>> not run by default. As a result, this syntax test runs every time you
>> run the 'meson test'. This behaviour differs from Autoconf, but I
>> think it is acceptable.
Actually, I've been meaning to complain about the fact that these
checks aren't run by the default Makefile target. I never remember
that there is a separate "check" target, and even if I did remember
it's mostly useless to me because I always want to look at the
rendered HTML. So when I'm working on the docs I always just say
"make" in the doc/src/sgml directory. It'd be helpful, at least to
me, if the default target ran the tabs and nbsp checks. It already
does run xmllint, so that change could probably be integrated with
what you've done here without too much trouble.
> This got preempted slightly by Tom's commit 170a8a3f460, but I think
> it's worth doing. I tried to simplify it some. See attached. There
> doesn't seem to me to be any point in using a different set of files for
> the tab tests and the NBSP tests. If we use the same set of files we can
> improve the efficiency easily by opening them only once. Here we just
> look for all the sgml files and all the xsl files and process them all.
+1 for merging those two checks into one pass, especially if we're
to run them by default.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2025-09-30 20:42:35 | Re: Add jsonb_translate(jsonb, from, to) |
Previous Message | Andrew Dunstan | 2025-09-30 19:48:03 | Re: split func.sgml to separated individual sgml files |