Re: Remaining dependency on setlocale()

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Remaining dependency on setlocale()
Date: 2026-01-06 22:20:37
Message-ID: 5267a39d41a00d5d5b3342f10c835cc9e3e27a2c.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2026-01-06 at 20:54 +0100, Peter Eisentraut wrote:
> On further reflection, it seems just as easy to have dmetaphone()
> take
> the input collation and use that to do a proper collation-aware
> upper-casing.  This has the same effect (that is, it will still only
> support certain single-byte encodings), but it avoids elaborately
> hard-coding a bunch of things, and if we ever want to make this
> multibyte-aware, then we'll have to go this way anyway, I think.  See
> attached patch.

Looks good to me.

After you commit that, we still need the changes in fuzzystrmatch.c,
right?

Regards,
Jeff Davis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message surya poondla 2026-01-06 22:26:13 Re: [PATCH] psql: tab completion for ALTER ROLE ... IN DATABASE ...
Previous Message Jeff Davis 2026-01-06 22:10:51 Re: Speed up ICU case conversion by using ucasemap_utf8To*()